Issue 6614027: Remove obsolete variable pass through.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6614027: Remove obsolete variable pass through. (Closed)

Created:
9 years, 9 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
djmm

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Remove obsolete variable pass through. BUG=chromium-os:12711 TEST=enter_chroot, build_package, build_image Change-Id: I002ccdaba2c91421da22db2d5a52e82665eab6af Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=47974d4

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	enter_chroot.sh	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

djmm

http://codereview.chromium.org/6614027/diff/1/enter_chroot.sh File enter_chroot.sh (right): http://codereview.chromium.org/6614027/diff/1/enter_chroot.sh#newcode3 enter_chroot.sh:3: # Copyright (c) 2009 The Chromium OS Authors. All ...

9 years, 9 months ago (2011-03-03 22:52:49 UTC) #2

petkov

PTAL http://codereview.chromium.org/6614027/diff/1/enter_chroot.sh File enter_chroot.sh (right): http://codereview.chromium.org/6614027/diff/1/enter_chroot.sh#newcode3 enter_chroot.sh:3: # Copyright (c) 2009 The Chromium OS Authors. ...

9 years, 9 months ago (2011-03-03 23:29:23 UTC) #3

LGTM

Expand Messages | Collapse Messages