Issue 6614020: [login_manager] Clean up error message logging/glib error reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6614020: [login_manager] Clean up error message logging/glib error reporting (Closed)

Created:
9 years, 9 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
rginda

CC:
chromium-os-reviews_chromium.org, Chris Masone

Base URL:
http://git.chromium.org/git/login_manager.git@master

Visibility:
Public.

Description

[login_manager] Clean up error message logging/glib error reporting BUG=none TEST=unit tests Change-Id: Ic88ef7e3b5ebd4a0378a2c6e031cd563dbbc001f Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e60a184

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -61 lines)			Patch
	M	session_manager_service.cc	View		17 chunks	+62 lines, -61 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rginda

9 years, 9 months ago (2011-03-03 18:24:35 UTC) #2

LGTM

FYI, Ken just landed a patch to add syslog logging in libchromeos.

See http://codereview.chromium.org/6509006/ and
http://codereview.chromium.org/6594001/.

Expand Messages | Collapse Messages