Issue 6614017: X64 Crankshaft: Fix and enable StoreContextSlot in lithium codegen on x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6614017: X64 Crankshaft: Fix and enable StoreContextSlot in lithium codegen on x64. (Closed)

Created:
9 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 Crankshaft: Fix and enable StoreContextSlot in lithium codegen on x64. Committed: http://code.google.com/p/v8/source/detail?r=7048

Patch Set 2 : '' #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -25 lines)			Patch
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	1 chunk	+8 lines, -10 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	2 chunks	+7 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/6614017/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6614017/diff/1/src/x64/lithium-codegen-x64.cc#newcode1981 src/x64/lithium-codegen-x64.cc:1981: __ movq(scratch_1, rsi); Maybe we should call scratc_1 ...

9 years, 9 months ago (2011-03-03 14:30:28 UTC) #2

William Hesse

9 years, 9 months ago (2011-03-03 15:36:02 UTC) #3

http://codereview.chromium.org/6614017/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6614017/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:1981: __ movq(scratch_1, rsi);
On 2011/03/03 14:30:28, Rico wrote:
> Maybe we should  call scratc_1 for context and scratch_2 for scratch here?

I don't think so, since it will be confusing if we do shift to an impermanent
context register as on ia32 later.

Expand Messages | Collapse Messages

Issue 6614017: X64 Crankshaft: Fix and enable StoreContextSlot in lithium codegen on x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages