Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 6614017: X64 Crankshaft: Fix and enable StoreContextSlot in lithium codegen on x64. (Closed)

Created:
9 years, 9 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

X64 Crankshaft: Fix and enable StoreContextSlot in lithium codegen on x64. Committed: http://code.google.com/p/v8/source/detail?r=7048

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -25 lines) Patch
M src/x64/lithium-codegen-x64.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +8 lines, -10 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
9 years, 9 months ago (2011-03-03 14:16:02 UTC) #1
Rico
LGTM http://codereview.chromium.org/6614017/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6614017/diff/1/src/x64/lithium-codegen-x64.cc#newcode1981 src/x64/lithium-codegen-x64.cc:1981: __ movq(scratch_1, rsi); Maybe we should call scratc_1 ...
9 years, 9 months ago (2011-03-03 14:30:28 UTC) #2
William Hesse
9 years, 9 months ago (2011-03-03 15:36:02 UTC) #3
http://codereview.chromium.org/6614017/diff/1/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):

http://codereview.chromium.org/6614017/diff/1/src/x64/lithium-codegen-x64.cc#...
src/x64/lithium-codegen-x64.cc:1981: __ movq(scratch_1, rsi);
On 2011/03/03 14:30:28, Rico wrote:
> Maybe we should  call scratc_1 for context and scratch_2 for scratch here?

I don't think so, since it will be confusing if we do shift to an impermanent
context register as on ia32 later.

Powered by Google App Engine
This is Rietveld 408576698