Issue 6614006: vboot/make_dev_firmware: extract bitmaps from system firmware instead of prebuilts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6614006: vboot/make_dev_firmware: extract bitmaps from system firmware instead of prebuilts. (Closed)

Created:
9 years, 9 months ago by Hung-Te

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git@master

Visibility:
Public.

Description

vboot/make_dev_firmware: extract bitmaps from system firmware instead of prebuilts. make_dev_firmware should trust system firmware blobs instead of using its own prebuilt binaries. BUG=chromium-os:12400 TEST=1. make a build with .49+ BIOS, and create the firmware updater 2. install the new BIOS, turn on developer switch and reboot 3. an ugly "DEV" screen (in .49) is shown on screen 4. run the new make_dev_firmware.sh 5. reboot. seeing the ugly DEV instead of the prebuilt blue screen (verified successfully) Change-Id: If75d2821170649fa869db6a82d879b697f7588e6 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=f82f4ae

Patch Set 1 #

Total comments: 2

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -6 lines)			Patch
	M	scripts/image_signing/make_dev_firmware.sh	View		5 chunks	+40 lines, -6 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Randall Spangler

LGTM http://codereview.chromium.org/6614006/diff/1/scripts/image_signing/make_dev_firmware.sh File scripts/image_signing/make_dev_firmware.sh (right): http://codereview.chromium.org/6614006/diff/1/scripts/image_signing/make_dev_firmware.sh#newcode17 scripts/image_signing/make_dev_firmware.sh:17: DEFAULT_BMPFV_FILE="<auto>" Using '<auto>' intentionally because it's hard to ...

9 years, 9 months ago (2011-03-07 20:44:19 UTC) #2

Hung-Te

9 years, 9 months ago (2011-03-08 01:21:46 UTC) #3

Thanks for the review.

http://codereview.chromium.org/6614006/diff/1/scripts/image_signing/make_dev_...
File scripts/image_signing/make_dev_firmware.sh (right):

http://codereview.chromium.org/6614006/diff/1/scripts/image_signing/make_dev_...
scripts/image_signing/make_dev_firmware.sh:17: DEFAULT_BMPFV_FILE="<auto>"
On 2011/03/07 20:44:21, Randall Spangler wrote:
> Using '<auto>' intentionally because it's hard to type in a shell?
Yes.

Expand Messages | Collapse Messages