Add a parameter to CreateAudioStream to choose between standard and low-latency mode.

Add a parameter to CreateAudioStream to choose between standard and low-latency mode.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42291

[sehr (please use chromium), 2010-03-02 22:35:44]

Other than the trybot disasters, LGTM.

[cpu_(ooo_6.6-7.5), 2010-03-02 22:53:23]

lgtm

You should send a heads up or fyi to the kirkland <video> people.

[scherkus (not reviewing), 2010-03-02 22:59:53]

http://codereview.chromium.org/661386/diff/16/19
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/661386/diff/16/19#newcode1818
chrome/common/render_messages_internal.h:1818: bool /* low-latency */)
Curious why we didn't add low_latency to ViewHostMsg_Audio_CreateStream_Params
struct

[neb, 2010-03-02 23:33:38]

http://codereview.chromium.org/661386/diff/16/19
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/661386/diff/16/19#newcode1818
chrome/common/render_messages_internal.h:1818: bool /* low-latency */)
On 2010/03/02 22:59:53, scherkus wrote:
> Curious why we didn't add low_latency to ViewHostMsg_Audio_CreateStream_Params
> struct

Yeah, I was thinking about it, but it made more sense to add it as a param to
the function, since it has nothing really to do with the audio format like the
other params had, but more with the internal plumbing, i.e. do we use sockets or
not.
Any benefits in going the other way?

[scherkus (not reviewing), 2010-03-03 00:26:24]

The benefits would be not changing the call sites, but you already took care of
that :)

Typically _Params structs are used when we start having a lot of parameters, as
we do with CreateAudioStream.  grepping through render_messages_internal.h it
looks like nearly all IPC functions with a _Params struct do not include
additional parameters, so my only argument would be for the sake of consistency.

[fbarchard, 2010-03-03 01:30:43]

drive by comment
just my usual cautionary note, that this will likely cause clicking on vista64
until we get a dsound driver.

[sehr (please use chromium), 2010-03-19 15:47:55]

On 2010/03/03 01:30:43, fbarchard wrote:
> drive by comment
> just my usual cautionary note, that this will likely cause clicking on vista64
> until we get a dsound driver.

Neb,

Where are we on this?  I would like to get a reliable way to cause low-latency
audio created for NaCl.

Thanks,

David