Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 661367: Refactor the scanner interface... (Closed)

Created:
10 years, 9 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor the scanner interface No need to create sub strings for lazy compiles. The scanner will start from the start position provided. Moved the creating of character streams into the scanner where possible. This uses a input buffer in the scanner class instead of a stack allocated one. Added a UTF16 buffer for reading external ascii strings (by templating the external two byte string one) as all the source for the builtins are exposed as external ascii strings. Committed: http://code.google.com/p/v8/source/detail?r=4007

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -75 lines) Patch
M src/objects.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 1 9 chunks +16 lines, -20 lines 0 comments Download
M src/scanner.h View 1 6 chunks +45 lines, -22 lines 0 comments Download
M src/scanner.cc View 1 8 chunks +73 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-02 13:11:00 UTC) #1
Mads Ager (chromium)
10 years, 9 months ago (2010-03-03 13:04:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698