Rewrite MakeDay function from JS to C++.

Rewrite MakeDay function from JS to C++.


Committed: http://code.google.com/p/v8/source/detail?r=3997

[Mads Ager (chromium), 2010-03-02 13:04:08]

LGTM with a couple of comments.

http://codereview.chromium.org/661366/diff/1/3
File src/date-delay.js (right):

http://codereview.chromium.org/661366/diff/1/3#newcode368
src/date-delay.js:368: // Now we presume that year, month and date are actually
SMIs.
Since the runtime function probably relies on year, month and date being Smis,
we have to be 100% sure that they are.  Could you update the comment explaining
why they have to be Smis?

http://codereview.chromium.org/661366/diff/1/4
File src/runtime.cc (right):

http://codereview.chromium.org/661366/diff/1/4#newcode4955
src/runtime.cc:4955: int day_from_year = 365*year + (year - 1)/4 - (year -
1)/100 + (year - 1)/400 - base_day;
Line too long, please reformat.  Also, please have a space around arithmetic
operations and use parenthesis to make the precedence explicit.

[Oleg Eterevsky, 2010-03-02 13:28:23]

http://codereview.chromium.org/661366/diff/1/3
File src/date-delay.js (right):

http://codereview.chromium.org/661366/diff/1/3#newcode368
src/date-delay.js:368: // Now we presume that year, month and date are actually
SMIs.
On 2010/03/02 13:04:08, Mads Ager wrote:
> Since the runtime function probably relies on year, month and date being Smis,
> we have to be 100% sure that they are.  Could you update the comment
explaining
> why they have to be Smis?

Done.

http://codereview.chromium.org/661366/diff/1/4
File src/runtime.cc (right):

http://codereview.chromium.org/661366/diff/1/4#newcode4955
src/runtime.cc:4955: int day_from_year = 365*year + (year - 1)/4 - (year -
1)/100 + (year - 1)/400 - base_day;
I tried to reformat it to make it more readable, avoiding extra parentheses.
Hope, it's ok now.

On 2010/03/02 13:04:08, Mads Ager wrote:
> Line too long, please reformat.  Also, please have a space around arithmetic
> operations and use parenthesis to make the precedence explicit.