Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 661354: Mac: Select right tab in content settings dialog. (Closed)

Created:
10 years, 9 months ago by Nico
Modified:
9 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Mac: Select right tab in content settings dialog. Also fix an unrelated TODO in this area. xib change: Make ContentSettingsWindowController the NSTabView's delegate and hook the controller's IBOutlet up to the NSTabView. BUG=36949 TEST=Open content settings via a blocked popups bubble. Popup tab should be selected. Select javascript tab, close window. Reopen window, javascript tab should still be selected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40362

Patch Set 1 #

Patch Set 2 : connect iboutlet in xib #

Patch Set 3 : '' #

Patch Set 4 : observer #

Total comments: 9

Patch Set 5 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -6 lines) Patch
M base/cocoa_protocols_mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/nibs/ContentSettings.xib View 1 4 chunks +22 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/content_settings_dialog_controller.h View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/cocoa/content_settings_dialog_controller.mm View 1 2 3 4 6 chunks +47 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
The xib file is amazingly clean.
10 years, 9 months ago (2010-03-02 04:50:31 UTC) #1
Nico
On 2010/03/02 04:50:31, Nico wrote: > The xib file is amazingly clean. (the diff, that ...
10 years, 9 months ago (2010-03-02 04:53:30 UTC) #2
viettrungluu
http://codereview.chromium.org/661354/diff/19/1004 File chrome/browser/cocoa/content_settings_dialog_controller.h (right): http://codereview.chromium.org/661354/diff/19/1004#newcode34 chrome/browser/cocoa/content_settings_dialog_controller.h:34: - (void)selectTab:(ContentSettingsType)settingsType; Why should this be public? http://codereview.chromium.org/661354/diff/19/1005 File ...
10 years, 9 months ago (2010-03-02 05:02:24 UTC) #3
Nico
http://codereview.chromium.org/661354/diff/19/1004 File chrome/browser/cocoa/content_settings_dialog_controller.h (right): http://codereview.chromium.org/661354/diff/19/1004#newcode34 chrome/browser/cocoa/content_settings_dialog_controller.h:34: - (void)selectTab:(ContentSettingsType)settingsType; On 2010/03/02 05:02:24, viettrungluu wrote: > Why ...
10 years, 9 months ago (2010-03-02 05:06:35 UTC) #4
viettrungluu
10 years, 9 months ago (2010-03-02 05:12:38 UTC) #5
LGTM.

http://codereview.chromium.org/661354/diff/19/1005
File chrome/browser/cocoa/content_settings_dialog_controller.mm (right):

http://codereview.chromium.org/661354/diff/19/1005#newcode151
chrome/browser/cocoa/content_settings_dialog_controller.mm:151:
lastSelectedTab_.SetValue(index);
On 2010/03/02 05:06:37, Nico wrote:
> On 2010/03/02 05:02:24, viettrungluu wrote:
> > Or, if you're lazy, you can do |else NOTREACHED()|.
> 
> Done.

Done.

Powered by Google App Engine
This is Rietveld 408576698