Issue 661333: Change some desktop notifications layout parameters to be per-platform rather...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661333: Change some desktop notifications layout parameters to be per-platform rather... (Closed)

Created:
10 years, 9 months ago by John Gregg

Modified:
9 years ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Change some desktop notifications layout parameters to be per-platform rather than universal, and put mac notifications in the upper right as requested. BUG=34826 TEST=create notifications on all platforms Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40343

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -25 lines)			Patch
M	chrome/browser/notifications/balloon_collection.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection.cc	View		4 chunks	+15 lines, -25 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_linux.cc	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_mac.mm	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_collection_win.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Andrew T Wilson (Slow)

10 years, 9 months ago (2010-03-02 01:21:27 UTC) #2

LGTM. It's odd that a vertical margin of 18 works on the Mac, though given that
the menu bar > 18 pixels high.

Expand Messages | Collapse Messages