Issue 661327: Fix the content page of the options dialog to use kAutoFillEnabled instead of...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661327: Fix the content page of the options dialog to use kAutoFillEnabled instead of... (Closed)

Created:
10 years, 9 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
GeorgeY

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix the content page of the options dialog to use kAutoFillEnabled instead of the obsolete kFormAutofillEnabled. BUG=36640 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40345

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
M	chrome/browser/cocoa/preferences_window_controller.mm	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/options/content_page_gtk.cc	View		3 chunks	+4 lines, -2 lines	2 comments	Download
M	chrome/browser/options_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/options/content_page_view.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

GeorgeY

LGTM With one question http://codereview.chromium.org/661327/diff/1011/14 File chrome/browser/gtk/options/content_page_gtk.cc (right): http://codereview.chromium.org/661327/diff/1011/14#newcode7 chrome/browser/gtk/options/content_page_gtk.cc:7: #include <string> Is explicit <string> ...

10 years, 9 months ago (2010-03-02 01:30:26 UTC) #2

James Hawkins

10 years, 9 months ago (2010-03-02 01:31:31 UTC) #3

http://codereview.chromium.org/661327/diff/1011/14
File chrome/browser/gtk/options/content_page_gtk.cc (right):

http://codereview.chromium.org/661327/diff/1011/14#newcode7
chrome/browser/gtk/options/content_page_gtk.cc:7: #include <string>
On 2010/03/02 01:30:26, GeorgeY wrote:
> Is explicit <string> inclusion needed? I do not see any changes requiring this
> addition...

Yes, std::string is used on line 166 w/out the proper include.

Expand Messages | Collapse Messages