Add GTalk Playground test into ChromeOS autotest.

Add GTalk Playground test into ChromeOS autotest.




Add GTalk Playground test into ChromeOS.

[zhurunz, 2010-03-01 22:40:38]

Add Playground into ChromeOS autotest.

Playground is a GTalk testing/debugging tool. Here we use it as part of the
ChromeOS testing.
The end-to-end tests exercise audio/video device to a degree GTalk is happy.

Files other than *.py/options/control are ported from Playground codebase
(google3).

[Tristan Schmelcher 2, 2010-03-01 22:46:31]

LGTM

[petkov, 2010-03-01 22:58:19]

A few comments/questions.

Do you intend to maintain the Playground sources here or is there another place
where the master sources live? If the latter, then it might be best to just
check-in a tarball of the sources and unpack them through the "setup" method --
see system_SAT for example. This way it's clear where the master sources come
from and how updates can happen.

http://codereview.chromium.org/661307/diff/1/660
File
client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py
(right):

http://codereview.chromium.org/661307/diff/1/660#newcode14
client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py:14:
utils.run('killall chrome', ignore_status=True)
I don't think there's killall on the latest image and... do you really need to
kill chrome?

http://codereview.chromium.org/661307/diff/1/660#newcode22
client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py:22:
cmd = "chown chronos %s -R" % os.path.join(self.bindir, '')
Hopefull this chown doesn't cause trouble in the future... I still think doing
this sort of stuff in tmpdir is generally a better idea.

[zhurunz, 2010-03-02 00:54:20]

Thanks a lot for the review, Darin!
Very good feedback.

I have compress everything of Playground into a tar.
Also moved playground to /home/chronos/Playground which is more appropriate.
Please have another review.

http://codereview.chromium.org/661307/diff/1/660
File
client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py
(right):

http://codereview.chromium.org/661307/diff/1/660#newcode14
client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py:14:
utils.run('killall chrome', ignore_status=True)
On 2010/03/01 22:58:19, petkov wrote:
> I don't think there's killall on the latest image and... do you really need to
> kill chrome?

I do need it for clean up. Otherwise, there could be an existing playground page
still running and could mess up the log and test results.

http://codereview.chromium.org/661307/diff/1/660#newcode22
client/site_tests/realtimecomm_GTalkPlayground/realtimecomm_GTalkPlayground.py:22:
cmd = "chown chronos %s -R" % os.path.join(self.bindir, '')
On 2010/03/01 22:58:19, petkov wrote:
> Hopefull this chown doesn't cause trouble in the future... I still think doing
> this sort of stuff in tmpdir is generally a better idea.
> 

Done.

[zhurunz, 2010-03-02 18:28:41]

Upload for review.

[petkov, 2010-03-02 18:47:08]

This is better but not there yet. The idea is that we run the setup method once
as part of build_autotest.sh on the build host -- in this setup step tests can
cross compile, patch, etc -- with tools that are not available on the target
device. And it all should stay under the test folder so that we can run autoserv
from there as well as package it up and ship it.  Then on the target device the
setup step should not actually run. The magic happens by the test creating the
"srcdir" and autotest placing a .version file in there.

Currently, your setup will run once on the build host and put stuff in the dev
chroot that nobody cares about. Then it would run again on the target device.

If you want to install stuff outside the test folder, you should either do it in
an initialize method, or in a run_once method. However, you would rely on
"tar/gzip" being available on the device -- which it currently is and probably
will be.

One nice thing about keeping things in self.srcdir and self.tmpdir is that you
can just remove /home/autotest from the target device and all testing stuff
disappears.

So: either fix it so that you untar the sources into self.srcdir (so that the
sources are untarred only once), or move untarring to initialize or run_once
(and maybe use self.tmpdir).

[zhurunz, 2010-03-02 19:07:49]

I see. Thanks for the catch!

OK, I untar into src now.
In the setup, I copy the files.
In the cleanup, remove the files.

[petkov, 2010-03-02 19:37:43]

LGTM