Adds memory cache logging, and updates disk cache logging

Adds memory cache logging, and updates disk cache logging.

Memory and disk cache use the same set of events, with the same parameters (Though the disk cache has a couple events the memory cache does not).  Most disk cache events were renamed so as to no longer imply a connection to the disk cache, and all disk cache-related NetLog parameter class definitions were moved to a new file, since they're shared by both entry type.

BUG=59382
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=78572

[eroman, 2011-03-04 05:06:02]

Hi Matthew, I am going to be on vacation tomorrow and monday.
If it is time critical then consider an LGTM from rvargas as sufficient,
otherwise I would like to review the netlog parts when I return. Cheers.

[mmenke, 2011-03-04 05:09:55]

On 2011/03/04 05:06:02, eroman wrote:
> Hi Matthew, I am going to be on vacation tomorrow and monday.
> If it is time critical then consider an LGTM from rvargas as sufficient,
> otherwise I would like to review the netlog parts when I return. Cheers.

Time's not at all critical - I don't think there's any real need for this to go
into M11.

[rvargas (doing something else), 2011-03-04 21:39:16]

Looks pretty good.

http://codereview.chromium.org/6613027/diff/2006/net/disk_cache/sparse_contro...
File net/disk_cache/sparse_control.cc (right):

http://codereview.chromium.org/6613027/diff/2006/net/disk_cache/sparse_contro...
net/disk_cache/sparse_control.cc:639: if (operation_ != kGetRangeOperation) {
nit: reverse this if

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
File net/disk_cache/mem_entry_impl.cc (left):

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.cc:452: MemEntryImpl* child = new
MemEntryImpl(backend_);
This creates a child entry that will miss the BeginEvent (doesn't go through
CreateEntry), but will see the EndEvent on the destructor.

The use case is a sparse incognito cache (for media).

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
File net/disk_cache/mem_entry_impl.cc (right):

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.cc:58:
net::NetLog::TYPE_DISK_CACHE_MEM_ENTRY_IMPL,
nit: indent four spaces

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.cc:179: int MemEntryImpl::InternalReadData(int
index, int offset, net::IOBuffer* buf,
I appreciate this being here for the review, but it has to move down before
commit.

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.cc:222: int buf_len, bool truncate) {
nit: could you indent these under index.

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
File net/disk_cache/mem_entry_impl.h (right):

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.h:121: int InternalReadData(int index, int offset,
net::IOBuffer* buf, int buf_len);
nit: Add a comment for this block of methods.

[mmenke, 2011-03-07 17:46:40]

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
File net/disk_cache/mem_entry_impl.cc (left):

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.cc:452: MemEntryImpl* child = new
MemEntryImpl(backend_);
On 2011/03/04 21:39:16, rvargas wrote:
> This creates a child entry that will miss the BeginEvent (doesn't go through
> CreateEntry), but will see the EndEvent on the destructor.
> 
> The use case is a sparse incognito cache (for media).

Fixed.  I should add that both a build from the top of trunk and Canary have
been having renderer crashes on HTML5 video, so I haven't been able to test
output for sparse operations.

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
File net/disk_cache/mem_entry_impl.cc (right):

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.cc:58:
net::NetLog::TYPE_DISK_CACHE_MEM_ENTRY_IMPL,
On 2011/03/04 21:39:16, rvargas wrote:
> nit: indent four spaces

Done.

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.cc:179: int MemEntryImpl::InternalReadData(int
index, int offset, net::IOBuffer* buf,
On 2011/03/04 21:39:16, rvargas wrote:
> I appreciate this being here for the review, but it has to move down before
> commit.

Once Eric's had a chance to review, I'll move them.

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.cc:222: int buf_len, bool truncate) {
On 2011/03/04 21:39:16, rvargas wrote:
> nit: could you indent these under index.

Done.

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
File net/disk_cache/mem_entry_impl.h (right):

http://codereview.chromium.org/6613027/diff/10001/net/disk_cache/mem_entry_im...
net/disk_cache/mem_entry_impl.h:121: int InternalReadData(int index, int offset,
net::IOBuffer* buf, int buf_len);
On 2011/03/04 21:39:16, rvargas wrote:
> nit: Add a comment for this block of methods.

Done.

[rvargas (doing something else), 2011-03-07 22:13:51]

LGTM, Thanks.

http://codereview.chromium.org/6613027/diff/2006/net/disk_cache/sparse_contro...
File net/disk_cache/sparse_control.cc (right):

http://codereview.chromium.org/6613027/diff/2006/net/disk_cache/sparse_contro...
net/disk_cache/sparse_control.cc:639: if (operation_ != kGetRangeOperation) {
On 2011/03/04 21:39:16, rvargas wrote:
> nit: reverse this if

I guess you missed this one.

[mmenke, 2011-03-07 22:19:24]

http://codereview.chromium.org/6613027/diff/2006/net/disk_cache/sparse_contro...
File net/disk_cache/sparse_control.cc (right):

http://codereview.chromium.org/6613027/diff/2006/net/disk_cache/sparse_contro...
net/disk_cache/sparse_control.cc:639: if (operation_ != kGetRangeOperation) {
On 2011/03/07 22:13:51, rvargas wrote:
> On 2011/03/04 21:39:16, rvargas wrote:
> > nit: reverse this if
> 
> I guess you missed this one.

Yea, I did.  Thanks for catching it.  Done.

[eroman, 2011-03-15 23:58:44]

LGTM.

sorry for taking so long! (i have been consumed with a top-crash on M11 and
de-prioritizing reviews.)

http://codereview.chromium.org/6613027/diff/17001/net/base/net_log_event_type...
File net/base/net_log_event_type_list.h (right):

http://codereview.chromium.org/6613027/diff/17001/net/base/net_log_event_type...
net/base/net_log_event_type_list.h:569: //     "offset": <Offset at which to
start reading>;
nit: please use commas rather than semicolons, to match the other comments. (it
is pseudo-JSON).

[mmenke, 2011-03-16 05:31:54]

Thanks.

That's the crash Randy is also working on, isn't it?  Not a problem.

http://codereview.chromium.org/6613027/diff/17001/net/base/net_log_event_type...
File net/base/net_log_event_type_list.h (right):

http://codereview.chromium.org/6613027/diff/17001/net/base/net_log_event_type...
net/base/net_log_event_type_list.h:569: //     "offset": <Offset at which to
start reading>;
On 2011/03/15 23:58:45, eroman wrote:
> nit: please use commas rather than semicolons, to match the other comments.
(it
> is pseudo-JSON).

You're right...I accidentally used some in a prior commit, so was copying from
the incorrect style.

A bunch of lines from earlier commits, a good chunk of them them mine, are also
missing commas.  I'll go ahead and fix the entire file while I'm at it.