Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issue 6613019: Revert change 7048 (Closed)

Created:
9 years, 9 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M src/x64/lithium-codegen-x64.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +10 lines, -8 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
William Hesse
9 years, 9 months ago (2011-03-03 16:08:16 UTC) #1
Rico
LGTM
9 years, 9 months ago (2011-03-03 16:09:36 UTC) #2
William Hesse
9 years, 9 months ago (2011-03-03 16:09:40 UTC) #3
This is obviously wrong, because LStoreContextSlot and LoadContextSlot take an
input context, in a register, that may not be the current context in rsi.

Powered by Google App Engine
This is Rietveld 408576698