Issue 6613015: ARM: Implement MathPowStub and DoMathPowHalf.

Issue 6613015: ARM: Implement MathPowStub and DoMathPowHalf. (Closed)

Created:
9 years, 9 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

ARM: Implement MathPowStub and DoMathPowHalf.

Patch Set 4 : Minor edits. #

Total comments: 10

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -17 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2 3	1 chunk	+101 lines, -0 lines	8 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 2 3	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 2 3	3 chunks	+19 lines, -4 lines	2 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#newcode4108 src/arm/code-stubs-arm.cc:4108: // C function for integer exponents. Maybe add ...

9 years, 9 months ago (2011-03-08 10:05:12 UTC) #2

Karl Klose

9 years, 9 months ago (2011-03-08 10:29:00 UTC) #3

http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4108: // C function for integer exponents.
On 2011/03/08 10:05:12, Søren Gjesse wrote:
> Maybe add a comment that heapnumber is callee saved.

Done.

http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4123: __ mov(result, heapnumber);
On 2011/03/08 10:05:12, Søren Gjesse wrote:
> I think it would be fine to just use r0 here and drop the variable "result".

Done.

http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4136: // double exponents.
On 2011/03/08 10:05:12, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/6613015/diff/6001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:4151: __ mov(result, heapnumber);
On 2011/03/08 10:05:12, Søren Gjesse wrote:
> Ditto.

Done.

http://codereview.chromium.org/6613015/diff/6001/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

http://codereview.chromium.org/6613015/diff/6001/src/arm/lithium-codegen-arm....
src/arm/lithium-codegen-arm.cc:2653: __ eor(scratch, scratch, Operand(scratch));
On 2011/03/08 10:05:12, Søren Gjesse wrote:
> On ARM just using mov(scratch, Operand(0)) should be fine for zeroing a
> register.

Done.

Expand Messages | Collapse Messages