Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/runtime.cc

Issue 6613005: Implementation of strict mode in SetElement. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix presubmit and merge conflicts. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1471 // should have been a const redeclaration error when declaring 1471 // should have been a const redeclaration error when declaring
1472 // the const property. 1472 // the const property.
1473 ASSERT(!holder.is_identical_to(context)); 1473 ASSERT(!holder.is_identical_to(context));
1474 if ((attributes & READ_ONLY) == 0) { 1474 if ((attributes & READ_ONLY) == 0) {
1475 Handle<Context>::cast(holder)->set(index, *value); 1475 Handle<Context>::cast(holder)->set(index, *value);
1476 } 1476 }
1477 } else { 1477 } else {
1478 // The holder is an arguments object. 1478 // The holder is an arguments object.
1479 ASSERT((attributes & READ_ONLY) == 0); 1479 ASSERT((attributes & READ_ONLY) == 0);
1480 Handle<JSObject> arguments(Handle<JSObject>::cast(holder)); 1480 Handle<JSObject> arguments(Handle<JSObject>::cast(holder));
1481 RETURN_IF_EMPTY_HANDLE(SetElement(arguments, index, value, kNonStrictMode) ); 1481 RETURN_IF_EMPTY_HANDLE(
1482 SetElement(arguments, index, value, kNonStrictMode));
1482 } 1483 }
1483 return *value; 1484 return *value;
1484 } 1485 }
1485 1486
1486 // The property could not be found, we introduce it in the global 1487 // The property could not be found, we introduce it in the global
1487 // context. 1488 // context.
1488 if (attributes == ABSENT) { 1489 if (attributes == ABSENT) {
1489 Handle<JSObject> global = Handle<JSObject>(Top::context()->global()); 1490 Handle<JSObject> global = Handle<JSObject>(Top::context()->global());
1490 // Strict mode not needed (const disallowed in strict mode). 1491 // Strict mode not needed (const disallowed in strict mode).
1491 RETURN_IF_EMPTY_HANDLE( 1492 RETURN_IF_EMPTY_HANDLE(
(...skipping 10131 matching lines...) Expand 10 before | Expand all | Expand 10 after
11623 } else { 11624 } else {
11624 // Handle last resort GC and make sure to allow future allocations 11625 // Handle last resort GC and make sure to allow future allocations
11625 // to grow the heap without causing GCs (if possible). 11626 // to grow the heap without causing GCs (if possible).
11626 Counters::gc_last_resort_from_js.Increment(); 11627 Counters::gc_last_resort_from_js.Increment();
11627 Heap::CollectAllGarbage(false); 11628 Heap::CollectAllGarbage(false);
11628 } 11629 }
11629 } 11630 }
11630 11631
11631 11632
11632 } } // namespace v8::internal 11633 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698