Issue 661275: Added implementation if Uint32::Value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661275: Added implementation if Uint32::Value. (Closed)

Created:
10 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
William Hesse, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Patch Set 2 : Added IsUint32 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -5 lines)			Patch
M	include/v8.h	View		4 chunks	+9 lines, -4 lines	0 comments	Download
M	src/api.cc	View	1	2 chunks	+23 lines, -0 lines	0 comments	Download
M	src/conversions.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/conversions-inl.h	View		1 chunk	+24 lines, -0 lines	1 comment	Download
M	test/cctest/test-api.cc	View	1	1 chunk	+89 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

William Hesse

On 2010/03/01 13:51:31, Lasse Reichstein wrote: > Small review. Did you also want to add ...

10 years, 9 months ago (2010-03-01 14:25:07 UTC) #2

Mads Ager (chromium)

LGTM http://codereview.chromium.org/661275/diff/1002/9 File src/conversions-inl.h (right): http://codereview.chromium.org/661275/diff/1002/9#newcode74 src/conversions-inl.h:74: if (negative) { x = -x; } Remove ...

10 years, 9 months ago (2010-03-03 13:16:50 UTC) #4

LGTM.

Expand Messages | Collapse Messages

Issue 661275: Added implementation if Uint32::Value. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Added IsUint32 #

Messages