Issue 661249: Working around gyp issue 137 in scons emitter....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661249: Working around gyp issue 137 in scons emitter.... (Closed)

Created:
10 years, 10 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
jiesun

CC:
chromium-reviews

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Description

Working around gyp issue 137 in scons emitter. The scons generator currently does not correctly handle the case in which you have a target with no sources (for instance all the mock targets used for the bots). So far this has not been an issue because these mock targets were only used for Windows and Mac. jiesun's recent addition of a chromeos_builder target caused this issue to manifest itself. BUG=None TEST=None TBR=jiesuN Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40229

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	build/all.gyp	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM  ( rubber stamp )

Expand Messages | Collapse Messages