Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Issue 661246: Logging-related changes. (Closed)

Created:
10 years, 10 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Logging-related changes. - when logging 'open-tag' / 'close-tag' events, don't depend on FLAG_log (as it may be not enabled, e.g. in Chromium); - PauseProfiler / ResumeProfiler were supposing that they use 'is_logging_' var exclusively, thus preventing any other logging that may be turned on for diagnostic purposes. Committed: http://code.google.com/p/v8/source/detail?r=3986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -26 lines) Patch
M src/log.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/log.cc View 6 chunks +20 lines, -12 lines 0 comments Download
M test/cctest/test-log.cc View 8 chunks +37 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mnaganov (inactive)
10 years, 10 months ago (2010-02-27 12:53:47 UTC) #1
Søren Thygesen Gjesse
10 years, 9 months ago (2010-03-01 10:15:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698