Adding the dependencies for mpstat, which is part of the sysstat package.

Adding the dependencies for mpstat, which is part of the sysstat package.

[ericli, 2010-02-27 18:45:24]

http://codereview.chromium.org/661240/diff/1/5
File client/deps/sysstat/sysstat.py (right):

http://codereview.chromium.org/661240/diff/1/5#newcode12
client/deps/sysstat/sysstat.py:12:
utils.get_file('http://pagesperso-orange.fr/sebastien.godard/sysstat-9.0.6.tar.gz',
tarball)
80 char in line length.
4 spaces in indentation

http://codereview.chromium.org/661240/diff/1/5#newcode15
client/deps/sysstat/sysstat.py:15: utils.system ('./configure --prefix=%s/mysql
--enable-thread-safe-client' \
prefix=%s/mysql?

http://codereview.chromium.org/661240/diff/1/5#newcode15
client/deps/sysstat/sysstat.py:15: utils.system ('./configure --prefix=%s/mysql
--enable-thread-safe-client' \
add CHOST and CBUILD for cross compiling.
See sample inside client/tests/dbench/dbench.py

http://codereview.chromium.org/661240/diff/1/5#newcode36
client/deps/sysstat/sysstat.py:36: tarball = os.path.join(pwd,
'mysql-5.0.45.tar.gz')
you want to install mysql inside chroot or on netbook?
seriously?

http://codereview.chromium.org/661240/diff/1/6
File client/tests/netperf2/netperf2.py (right):

http://codereview.chromium.org/661240/diff/1/6#newcode13
client/tests/netperf2/netperf2.py:13: def setup(self, tarball = 'netperf.tgz'):
why you change it to precompiled bundle?
I don think you should change this.

http://codereview.chromium.org/661240/diff/1/6#newcode140
client/tests/netperf2/netperf2.py:140: 
what is the deal to remove wait_time here?

http://codereview.chromium.org/661240/diff/1/6#newcode142
client/tests/netperf2/netperf2.py:142: # mpstat = os.path.join(self.srcdir,
'mpstat')
remove this comment line.

[kdlucas, 2010-03-01 17:54:18]

Oh, I grabbed the wrong files on Friday. I've uploaded the correct ones so take
a look now.

[ericli, 2010-03-01 18:03:24]

LGTM.

On 2010/03/01 17:54:18, kdlucas wrote:
> Oh, I grabbed the wrong files on Friday. I've uploaded the correct ones so
take
> a look now.