Issue 661235: Rename button from "Close" to "Done" on bookmark bubble and content bubbles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661235: Rename button from "Close" to "Done" on bookmark bubble and content bubbles. (Closed)

Created:
10 years, 10 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
Miranda Callahan

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Rename button from "Close" to "Done" on bookmark bubble and content bubbles. xib changes: Change ^IDS_CLOSE to ^IDS_DONE. BUG=36959 TEST=Open bookmark bubble. Button should read "Done". Go to popuptest.com, click "popups blocked" icon. Button in bubble should read "Done". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40202

Patch Set 1 #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -26 lines)			Patch
M	chrome/app/nibs/BookmarkBubble.xib	View	5 chunks	+12 lines, -4 lines	0 comments	Download
M	chrome/app/nibs/ContentBlockedCookies.xib	View	5 chunks	+18 lines, -3 lines	0 comments	Download
M	chrome/app/nibs/ContentBlockedImages.xib	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/app/nibs/ContentBlockedJavaScript.xib	View	7 chunks	+20 lines, -6 lines	0 comments	Download
M	chrome/app/nibs/ContentBlockedPlugins.xib	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/app/nibs/ContentBlockedPopups.xib	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_bubble_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/gtk/content_blocked_bubble_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/bookmark_bubble_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/views/content_blocked_bubble_contents.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Very deeply pleased by this change.
LGreatTM.

Expand Messages | Collapse Messages