Issue 661230: Fix ChromeOS crash when device_path is NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661230: Fix ChromeOS crash when device_path is NULL. (Closed)

Created:
10 years, 9 months ago by Charlie Lee

Modified:
9 years, 7 months ago

Reviewers:
DaveMoore, sky

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix ChromeOS crash when device_path is NULL. TEST=None BUG=1698 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40188

Patch Set 2 : '' #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/cros/network_library.cc	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/661230/diff/1/2 File chrome/browser/chromeos/cros/network_library.cc (right): http://codereview.chromium.org/661230/diff/1/2#newcode233 chrome/browser/chromeos/cros/network_library.cc:233: ethernet->device_path = service.device_path ? service.device_path : ""; nit: ...

10 years, 9 months ago (2010-02-27 01:01:25 UTC) #2

Charlie Lee

10 years, 9 months ago (2010-02-27 01:05:46 UTC) #3

Fixed. Will check in.

http://codereview.chromium.org/661230/diff/1/2
File chrome/browser/chromeos/cros/network_library.cc (right):

http://codereview.chromium.org/661230/diff/1/2#newcode233
chrome/browser/chromeos/cros/network_library.cc:233: ethernet->device_path =
service.device_path ? service.device_path : "";
On 2010/02/27 01:01:25, sky wrote:
> nit: we use std::string() rather than "" as it's slightly more efficient.

Done.

Expand Messages | Collapse Messages

Issue 661230: Fix ChromeOS crash when device_path is NULL. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages