Issue 661218: Fixed pyauto build for chromeos. Added proper sysroot and ability to specify ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661218: Fixed pyauto build for chromeos. Added proper sysroot and ability to specify ... (Closed)

Created:
10 years, 10 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed pyauto build for chromeos. Added proper sysroot and ability to specify python version. TEST=none BUG=none

Patch Set 4 : '' #

Total comments: 2

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	build/common.gypi	View	1 2 3	2 chunks	+4 lines, -0 lines	2 comments	Download
	M	chrome/chrome_tests.gypi	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

http://codereview.chromium.org/661218/diff/1006/11 File build/common.gypi (right): http://codereview.chromium.org/661218/diff/1006/11#newcode87 build/common.gypi:87: 'python_ver%': '2.5', btw, you did not refer to 2.6 ...

10 years, 9 months ago (2010-03-01 22:12:18 UTC) #3

zel

10 years, 9 months ago (2010-03-01 22:15:53 UTC) #4

http://codereview.chromium.org/661218/diff/1006/11
File build/common.gypi (right):

http://codereview.chromium.org/661218/diff/1006/11#newcode87
build/common.gypi:87: 'python_ver%': '2.5',
On 2010/03/01 22:12:19, Nirnimesh wrote:
> btw, you did not refer to 2.6 for chromeos anywhere?

That's done externally from Chrome OS ebuild file. See
http://codereview.chromium.org/660199/diff/1009/1010 for details.

Expand Messages | Collapse Messages

Issue 661218: Fixed pyauto build for chromeos. Added proper sysroot and ability to specify ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages