Issue 6612044: Added an SmsMessage class, and code for parsing a PDU to an SMS message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6612044: Added an SmsMessage class, and code for parsing a PDU to an SMS message. (Closed)

Created:
9 years, 9 months ago by Eric Shienbrood

Modified:
9 years, 7 months ago

Reviewers:
Jason Glasgow, rochberg

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@gitrw.chromium.org:9222/cromo.git@master

Visibility:
Public.

Description

Added an SmsMessage class, and code for parsing a PDU to an SMS message. This includes conversion of text encoded in the GSM-7 alphabet into a UTF-8 string. BUG=chromium-os:11302 TEST=Wrote unit tests for GSM-7 to UTF-8 conversion and for construction of SMS message from PDU. Also did live testing with a version of the gobi plugin that supports the ModemManager.Modem.Gsm.SMS.Get method, by sending actual SMS messages over the air to the modem and retrieving them using dbus-send to invoke the Get method. Change-Id: I26bb8bc764a9e7f4a81200740532e4874812f455 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8d9bc2d

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+652 lines, -28 lines)			Patch
M	Makefile	View	4 chunks	+10 lines, -5 lines	0 comments	Download
A	sms_message.h	View	1 chunk	+46 lines, -0 lines	0 comments	Download
A	sms_message.cc	View	1 chunk	+164 lines, -0 lines	0 comments	Download
A	sms_message_unittest.cc	View	1 chunk	+49 lines, -0 lines	0 comments	Download
M	utilities.h	View	1 chunk	+29 lines, -9 lines	0 comments	Download
M	utilities.cc	View	5 chunks	+221 lines, -12 lines	0 comments	Download
M	utilities_unittest.cc	View	2 chunks	+133 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages