Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6612025: [Mac] Apply CrTrackingArea to the two other places where we get |-mouseMoved:| zombie messages. (Closed)

Created:
9 years, 9 months ago by Robert Sesek
Modified:
9 years, 7 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

[Mac] Apply CrTrackingArea to the two other places where we get |-mouseMoved:| zombie messages. BUG=48709 TEST=Crash report numbers. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76976

Patch Set 1 #

Patch Set 2 : Add ScopedCrTrackingArea #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -9 lines) Patch
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tracking_area.h View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tracking_area.mm View 1 2 chunks +19 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tracking_area_unittest.mm View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
9 years, 9 months ago (2011-03-04 18:35:22 UTC) #1
Scott Hess - ex-Googler
http://codereview.chromium.org/6612025/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h (right): http://codereview.chromium.org/6612025/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h#newcode122 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h:122: scoped_nsobject<CrTrackingArea> scrollTrackingArea_; Can you think of any reason not ...
9 years, 9 months ago (2011-03-04 18:55:13 UTC) #2
Robert Sesek
http://codereview.chromium.org/6612025/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h File chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h (right): http://codereview.chromium.org/6612025/diff/2001/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h#newcode122 chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h:122: scoped_nsobject<CrTrackingArea> scrollTrackingArea_; On 2011/03/04 18:55:13, shess wrote: > Can ...
9 years, 9 months ago (2011-03-04 20:25:48 UTC) #3
Scott Hess - ex-Googler
9 years, 9 months ago (2011-03-04 21:29:32 UTC) #4 
lgtm!  thx

Powered by Google App Engine
This is Rietveld 408576698