Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 661178: Continue removing bad dependency of chrome/common on chrome/browser... (Closed)

Created:
10 years, 10 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews, jam+cc_chromium.org, brettw+cc_chromium.org, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Aaron Boodman, darin-cc_chromium.org, michaeln, pam+watch_chromium.org
Visibility:
Public.

Description

Continue removing bad dependency of chrome/common on chrome/browser TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40224

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -661 lines) Patch
A + chrome/browser/appcache/appcache_dispatcher_host.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/appcache/appcache_dispatcher_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + chrome/browser/appcache/appcache_frontend_proxy.h View 2 chunks +4 lines, -3 lines 0 comments Download
A + chrome/browser/appcache/appcache_frontend_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/appcache/chrome_appcache_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/appcache/chrome_appcache_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/automation_provider.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/automation/automation_provider_gtk.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_mac.mm View 1 2 chunks +27 lines, -0 lines 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data_appcache_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_url_request_context.h View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profile.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.h View 1 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 4 chunks +19 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 2 chunks +97 lines, -0 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/common/appcache/appcache_dispatcher_host.h View 1 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/common/appcache/appcache_dispatcher_host.cc View 1 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/common/appcache/appcache_frontend_proxy.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/common/appcache/appcache_frontend_proxy.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/common/appcache/chrome_appcache_service.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/common/appcache/chrome_appcache_service.cc View 1 1 chunk +0 lines, -97 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util_unittest.cc View 1 2 chunks +0 lines, -97 lines 0 comments Download
M chrome/common/platform_util.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/platform_util_linux.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/common/platform_util_mac.mm View 1 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/common/platform_util_win.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
10 years, 10 months ago (2010-02-26 14:29:54 UTC) #1
michaeln
lgtm I guess i'll have to get used to looking in one more directory for ...
10 years, 9 months ago (2010-02-26 16:43:14 UTC) #2
michaeln
http://codereview.chromium.org/661178/diff/1/29 File chrome/chrome_common.gypi (right): http://codereview.chromium.org/661178/diff/1/29#newcode187 chrome/chrome_common.gypi:187: 'common/appcache/appcache_frontend_proxy.h', i think we could also move appcache_frontend_proxy.cc h ...
10 years, 9 months ago (2010-02-26 16:48:07 UTC) #3
Erik does not do reviews
extension changes LGTM
10 years, 9 months ago (2010-02-26 18:01:32 UTC) #4
darin (slow to review)
LGTM
10 years, 9 months ago (2010-02-26 18:23:24 UTC) #5
Paweł Hajdan Jr.
10 years, 9 months ago (2010-02-27 13:01:55 UTC) #6 
On 2010/02/26 16:48:07, michaeln wrote:
> http://codereview.chromium.org/661178/diff/1/29
> File chrome/chrome_common.gypi (right):
> 
> http://codereview.chromium.org/661178/diff/1/29#newcode187
> chrome/chrome_common.gypi:187: 'common/appcache/appcache_frontend_proxy.h',
> i think we could also move appcache_frontend_proxy.cc h into the /browser
side?

Sure, done.

Powered by Google App Engine
This is Rietveld 408576698