Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: src/ia32/codegen-ia32.cc

Issue 661177: Moved initialization of xmm3 making sure it is initialized on all paths in Ge... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/codegen-ia32.cc
===================================================================
--- src/ia32/codegen-ia32.cc (revision 3966)
+++ src/ia32/codegen-ia32.cc (working copy)
@@ -5296,6 +5296,10 @@
ASSERT(x.is_valid());
ASSERT(y.is_valid());
+ // Save 1 in xmm3 - we need this several times later on
+ __ mov(p.reg(), Immediate(1));
+ __ cvtsi2sd(xmm3, Operand(p.reg()));
+
Label y_nonsmi;
Label x_is_double;
// If y is a heap number go to that specific case.
@@ -5321,10 +5325,8 @@
// Save y in x as we need to check if y is negative later.
__ mov(x.reg(), y.reg());
- // Save 1 in xmm3 - we need this several times later on
- __ mov(p.reg(), Immediate(1));
- __ cvtsi2sd(xmm3, Operand(p.reg()));
+
// Get absolute value of y.
Label no_neg;
__ cmp(y.reg(), 0);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698