Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: src/heap.cc

Issue 661173: Add an explicit API entry to notify V8 that one or more... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.cc
===================================================================
--- src/heap.cc (revision 3960)
+++ src/heap.cc (working copy)
@@ -371,7 +371,15 @@
}
-void Heap::CollectAllGarbageIfContextDisposed() {
+void Heap::CollectAllGarbageIfContextDisposed(bool notified) {
+ // If the request has ever been the result of an explicit
+ // notification, we ignore non-notified requests. This is a
+ // temporary solution to let the two ways of achieving GC at
+ // context disposal time co-exist.
+ static bool ever_notified = false;
+ if (notified) ever_notified = true;
+ if (ever_notified && !notified) return;
+
bakster 2010/02/26 11:46:42 Please change is so context_disposed_pending_ is N
// If the garbage collector interface is exposed through the global
// gc() function, we avoid being clever about forcing GCs when
// contexts are disposed and leave it to the embedder to make
« no previous file with comments | « src/heap.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698