Issue 661173: Add an explicit API entry to notify V8 that one or more...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661173: Add an explicit API entry to notify V8 that one or more... (Closed)

Created:
10 years, 10 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
bakster, bak

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add an explicit API entry to notify V8 that one or more contexts have been disposed. Committed: http://code.google.com/p/v8/source/detail?r=3971

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -3 lines)			Patch
M	include/v8.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/api.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	src/heap.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+9 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bakster

10 years, 10 months ago (2010-02-26 11:46:42 UTC) #2

LGTM,
  Lars

http://codereview.chromium.org/661173/diff/1/4
File src/heap.cc (right):

http://codereview.chromium.org/661173/diff/1/4#newcode382
src/heap.cc:382: 
Please change is so context_disposed_pending_ is NEVER used after notified ==
true.

Expand Messages | Collapse Messages