Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 661170: Add information about time spent in external callback to... (Closed)

Created:
10 years, 10 months ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
bak
CC:
v8-dev
Visibility:
Public.

Description

Add information about time spent in external callback to traces produces with --trace-gc. Committed: http://code.google.com/p/v8/source/detail?r=3960

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -5 lines) Patch
M src/heap.h View 2 chunks +19 lines, -1 line 0 comments Download
M src/heap.cc View 4 chunks +16 lines, -4 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
10 years, 10 months ago (2010-02-26 08:06:13 UTC) #1
bak
10 years, 10 months ago (2010-02-26 08:20:30 UTC) #2
LGTM,
  Lars

http://codereview.chromium.org/661170/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/661170/diff/1/2#newcode4093
src/heap.cc:4093: PrintF("%s %.1f -> %.1f MB, %d / %d ms.\n",
Refactor printing into:
PrintF(...);
if (external_time > 0) PrintF(...);
PrintF("\n");

Powered by Google App Engine
This is Rietveld 408576698