Issue 661170: Add information about time spent in external callback to...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 661170: Add information about time spent in external callback to... (Closed)

Created:
10 years, 10 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
bak

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add information about time spent in external callback to traces produces with --trace-gc. Committed: http://code.google.com/p/v8/source/detail?r=3960

Patch Set 1 #

Total comments: 1

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -5 lines)			Patch
	M	src/heap.h	View		2 chunks	+19 lines, -1 line	0 comments	Download
	M	src/heap.cc	View		4 chunks	+16 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bak

10 years, 10 months ago (2010-02-26 08:20:30 UTC) #2

LGTM,
  Lars

http://codereview.chromium.org/661170/diff/1/2
File src/heap.cc (right):

http://codereview.chromium.org/661170/diff/1/2#newcode4093
src/heap.cc:4093: PrintF("%s %.1f -> %.1f MB, %d / %d ms.\n",
Refactor printing into:
PrintF(...);
if (external_time > 0) PrintF(...);
PrintF("\n");

Expand Messages | Collapse Messages