Unifying NativeMetafile class interface (as much as possible) for Linux, Mac, Win

chrome/renderer/print_web_view_helper_linux.cc

Index: chrome/renderer/print_web_view_helper_linux.cc
diff --git a/chrome/renderer/print_web_view_helper_linux.cc b/chrome/renderer/print_web_view_helper_linux.cc
index 4798c71d7eeac2eef2f0aef4ffcf323d0cc3761c..29bd1b19d4b335ce0e668c9f50e37c5c57b8338a 100644
--- a/chrome/renderer/print_web_view_helper_linux.cc
+++ b/chrome/renderer/print_web_view_helper_linux.cc
@@ -82,7 +82,7 @@ void PrintWebViewHelper::PrintPages(const ViewMsg_PrintPages_Params& params,
                                                         &sequence_number))) {
     return;
   }
-  if (!metafile->SaveTo(fd))
+  if (!metafile->SaveToFD(fd))
     return;
 
   // Tell the browser we've finished writing the file.
@@ -212,12 +212,15 @@ void PrintWebViewHelper::PrintPage(const ViewMsg_PrintPage_Params& params,
                                 &margin_bottom_in_points,
                                 &margin_left_in_points);
 
+  gfx::Size page_size(
+      static_cast<int>(content_width_in_points + margin_right_in_points +

[vandebo (ex-Chrome), 2011/03/14 22:55:05]

A cast shouldn't be needed for double -> int conversion.  Did the compiler
complain?

[dpapad, 2011/03/15 16:11:06]

Done. No it didn't complain, I just thought it is better practice to avoid
implicit conversions in general.

+          margin_left_in_points),
+      static_cast<int>(content_height_in_points + margin_top_in_points +
+          margin_bottom_in_points));
+
   cairo_t* cairo_context =
-      metafile->StartPage(content_width_in_points,
-                          content_height_in_points,
+      metafile->StartPage(page_size,
                           margin_top_in_points,
-                          margin_right_in_points,
-                          margin_bottom_in_points,
                           margin_left_in_points);
   if (!cairo_context)
     return;