Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: printing/printed_document.cc

Issue 6611032: Unifying NativeMetafile class interface (as much as possible) for Linux, Mac, Win (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Making virtual methods not virtual (for clang bots) Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/pdf_ps_metafile_cairo_unittest.cc ('k') | printing/printing.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/printed_document.cc
diff --git a/printing/printed_document.cc b/printing/printed_document.cc
index 45603b575cc43c102485ae976abc1722e4a51f23..07eeec6dd901029043e4665c1241fbd6dd56c0b5 100644
--- a/printing/printed_document.cc
+++ b/printing/printed_document.cc
@@ -261,12 +261,14 @@ void PrintedDocument::DebugDump(const PrintedPage& page) {
filename += name();
filename += ASCIIToUTF16("_");
filename += ASCIIToUTF16(StringPrintf("%02d", page.page_number()));
- filename += ASCIIToUTF16("_.emf");
#if defined(OS_WIN)
+ filename += ASCIIToUTF16("_.emf");
page.native_metafile()->SaveTo(
- g_debug_dump_info.Get().debug_dump_path.Append(filename).value());
+ g_debug_dump_info.Get().debug_dump_path.Append(filename));
#else // OS_WIN
- NOTIMPLEMENTED(); // TODO: convert SaveTo to accept a FilePath
+ filename += ASCIIToUTF16("_.pdf");
+ page.native_metafile()->SaveTo(
+ g_debug_dump_info.Get().debug_dump_path.Append(UTF16ToUTF8(filename)));
#endif // OS_WIN
}
« no previous file with comments | « printing/pdf_ps_metafile_cairo_unittest.cc ('k') | printing/printing.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698