Unifying NativeMetafile class interface (as much as possible) for Linux, Mac, Win

printing/printed_document.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/printed_document.h"
 
 #include <algorithm>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 240 matching lines @@
   string16 filename;
   filename += date();
   filename += ASCIIToUTF16("_");
   filename += time();
   filename += ASCIIToUTF16("_");
   filename += name();
   filename += ASCIIToUTF16("_");
   filename += ASCIIToUTF16(StringPrintf("%02d", page.page_number()));
   filename += ASCIIToUTF16("_.emf");
 #if defined(OS_WIN)
-  page.native_metafile()->SaveTo(
-      g_debug_dump_info.Get().debug_dump_path.Append(filename).value());
+  page.native_metafile()->SaveTo(FilePath(
+      g_debug_dump_info.Get().debug_dump_path.Append(filename).value()));

[Lei Zhang, 2011/03/04 12:02:36]

I haven't looked closely, but I suspect
g_debug_dump_info.Get().debug_dump_path.Append(filename) is a FilePath. You
don't have to get its value() and construct another FilePath.

[dpapad, 2011/03/04 19:19:43]

Done.

 #else  // OS_WIN
   NOTIMPLEMENTED();  // TODO: convert SaveTo to accept a FilePath
 #endif  // OS_WIN
 }
 
 void PrintedDocument::set_debug_dump_path(const FilePath& debug_dump_path) {
   g_debug_dump_info.Get().enabled = !debug_dump_path.empty();
   g_debug_dump_info.Get().debug_dump_path = debug_dump_path;
 }
 
@@ skipping 19 matching lines @@
       name_(source->RenderSourceName()),
       url_(source->RenderSourceUrl()),
       cookie_(cookie) {
   SetDocumentDate();
 }
 
 PrintedDocument::Immutable::~Immutable() {
 }
 
 }  // namespace printing