Unifying NativeMetafile class interface (as much as possible) for Linux, Mac, Win

printing/emf_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/emf_win.h"
 
 #include "base/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/scoped_ptr.h"
@@ skipping 50 matching lines @@
   return emf_ != NULL;
 }
 
 bool Emf::CreateDc(HDC sibling, const RECT* rect) {
   DCHECK(!emf_ && !hdc_);
   hdc_ = CreateEnhMetaFile(sibling, NULL, rect, NULL);
   DCHECK(hdc_);
   return hdc_ != NULL;
 }
 
-bool Emf::CreateFileBackedDc(HDC sibling, const RECT* rect,
+bool Emf::CreateFileBackedDc(HDC sibling,

[vandebo (ex-Chrome), 2011/03/14 20:24:25]

Extra line break.

[dpapad, 2011/03/14 22:15:12]

Done.

+                             const RECT* rect,
                              const FilePath& path) {
   DCHECK(!emf_ && !hdc_);
   DCHECK(!path.empty());
   hdc_ = CreateEnhMetaFile(sibling, path.value().c_str(), rect, NULL);
   DCHECK(hdc_);
   return hdc_ != NULL;
 }
 
 bool Emf::CreateFromFile(const FilePath& metafile_path) {
   DCHECK(!emf_ && !hdc_);
   emf_ = GetEnhMetaFile(metafile_path.value().c_str());
   DCHECK(emf_);
   return emf_ != NULL;
 }
 
 
-bool Emf::CloseDc() {
+bool Emf::Close() {
   DCHECK(!emf_ && hdc_);
   emf_ = CloseEnhMetaFile(hdc_);
   DCHECK(emf_);
   hdc_ = NULL;
   return emf_ != NULL;
 }
 
 void Emf::CloseEmf() {
   DCHECK(!hdc_);
   if (emf_) {
     DeleteEnhMetaFile(emf_);
     emf_ = NULL;
   }
 }
 
 bool Emf::Playback(HDC hdc, const RECT* rect) const {
   DCHECK(emf_ && !hdc_);
   RECT bounds;
   if (!rect) {
     // Get the natural bounds of the EMF buffer.
-    bounds = GetBounds().ToRECT();
+    bounds = GetPageBounds(1).ToRECT();
     rect = &bounds;
   }
   return PlayEnhMetaFile(hdc, emf_, rect) != 0;
 }
 
 bool Emf::SafePlayback(HDC context) const {
   DCHECK(emf_ && !hdc_);
   XFORM base_matrix;
   if (!GetWorldTransform(context, &base_matrix)) {
     NOTREACHED();
     return false;
   }
   return EnumEnhMetaFile(context,
                          emf_,
                          &Emf::SafePlaybackProc,
                          reinterpret_cast<void*>(&base_matrix),
-                         &GetBounds().ToRECT()) != 0;
+                         &GetPageBounds(1).ToRECT()) != 0;
 }
 
-gfx::Rect Emf::GetBounds() const {
+gfx::Rect Emf::GetPageBounds(unsigned int page_number) const {
   DCHECK(emf_ && !hdc_);

[vandebo (ex-Chrome), 2011/03/14 20:24:25]

Add DCHECK_EQ(page_number, 1);

[dpapad, 2011/03/14 22:15:12]

Done. static_cast is necessary to avoid compilation error (comparing signed with
unsigned).

   ENHMETAHEADER header;
   if (GetEnhMetaFileHeader(emf_, sizeof(header), &header) != sizeof(header)) {
     NOTREACHED();
     return gfx::Rect();
   }
   if (header.rclBounds.left == 0 &&
       header.rclBounds.top == 0 &&
       header.rclBounds.right == -1 &&
       header.rclBounds.bottom == -1) {
     // A freshly created EMF buffer that has no drawing operation has invalid
@@ skipping 25 matching lines @@
   uint32 size = GetDataSize();
   if (!size)
     return false;
 
   buffer->resize(size);
   if (!GetData(&buffer->front(), size))
     return false;
   return true;
 }
 
-bool Emf::SaveTo(const std::wstring& filename) const {
-  HANDLE file = CreateFile(filename.c_str(), GENERIC_WRITE,
+bool Emf::SaveTo(const FilePath& file_path) const {
+  HANDLE file = CreateFile(file_path.value().c_str(), GENERIC_WRITE,
                            FILE_SHARE_READ | FILE_SHARE_WRITE, NULL,
                            CREATE_ALWAYS, 0, NULL);
   if (file == INVALID_HANDLE_VALUE)
     return false;
 
   bool success = false;
   std::vector<uint8> buffer;
   if (GetData(&buffer)) {
     DWORD written = 0;
     if (WriteFile(file, &*buffer.begin(), static_cast<DWORD>(buffer.size()),
                   &written, NULL) &&
         written == buffer.size()) {
       success = true;
     }
   }
   CloseHandle(file);
   return success;
 }
 
+bool Emf::StartPage() {

[vandebo (ex-Chrome), 2011/03/14 20:24:25]

No reason to move these methods.

[dpapad, 2011/03/14 22:15:12]

Done.

[vandebo (ex-Chrome), 2011/03/14 22:55:05]

The CR still shows them moved.  They used to be below SafePlayback

+  DCHECK(hdc_);
+  if (!hdc_)
+    return false;
+  PageBreakRecord record(PageBreakRecord::START_PAGE);
+  return !!GdiComment(hdc_, sizeof(record),
+                      reinterpret_cast<const BYTE *>(&record));
+}
+
+bool Emf::FinishPage() {
+  DCHECK(hdc_);
+  if (!hdc_)
+    return false;
+  PageBreakRecord record(PageBreakRecord::END_PAGE);
+  return !!GdiComment(hdc_, sizeof(record),
+                      reinterpret_cast<const BYTE *>(&record));
+}
+
 int CALLBACK Emf::SafePlaybackProc(HDC hdc,
                                    HANDLETABLE* handle_table,
                                    const ENHMETARECORD* record,
                                    int objects_count,
                                    LPARAM param) {
   const XFORM* base_matrix = reinterpret_cast<const XFORM*>(param);
   EnumerationContext context;
   context.handle_table = handle_table;
   context.objects_count = objects_count;
   context.hdc = hdc;
@@ skipping 195 matching lines @@
       break;
     }
     default: {
       res = Play();
       break;
     }
   }
   return res;
 }
 
-bool Emf::StartPage() {
-  DCHECK(hdc_);
-  if (!hdc_)
-    return false;
-  PageBreakRecord record(PageBreakRecord::START_PAGE);
-  return !!GdiComment(hdc_, sizeof(record),
-                      reinterpret_cast<const BYTE *>(&record));
-}
-
-bool Emf::EndPage() {
-  DCHECK(hdc_);
-  if (!hdc_)
-    return false;
-  PageBreakRecord record(PageBreakRecord::END_PAGE);
-  return !!GdiComment(hdc_, sizeof(record),
-                      reinterpret_cast<const BYTE *>(&record));
-}
-
-
 Emf::Enumerator::Enumerator(const Emf& emf, HDC context, const RECT* rect) {
   context_.handle_table = NULL;
   context_.objects_count = 0;
   context_.hdc = NULL;
   items_.clear();
   if (!EnumEnhMetaFile(context,
                        emf.emf(),
                        &Emf::Enumerator::EnhMetaFileProc,
                        reinterpret_cast<void*>(this),
                        rect)) {
@@ skipping 26 matching lines @@
   } else {
     DCHECK_EQ(emf.context_.handle_table, handle_table);
     DCHECK_EQ(emf.context_.objects_count, objects_count);
     DCHECK_EQ(emf.context_.hdc, hdc);
   }
   emf.items_.push_back(Record(&emf.context_, record));
   return 1;
 }
 
 }  // namespace printing