Unifying NativeMetafile class interface (as much as possible) for Linux, Mac, Win

printing/pdf_ps_metafile_cairo.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/pdf_ps_metafile_cairo.h"
 
 #include <stdio.h>
 
 #include <cairo.h>
 #include <cairo-pdf.h>
@@ skipping 199 matching lines @@
 }
 
 bool PdfPsMetafile::GetData(void* dst_buffer, uint32 dst_buffer_size) const {
   DCHECK(dst_buffer);
   DCHECK_GT(dst_buffer_size, 0u);
   memcpy(dst_buffer, data_.data(), dst_buffer_size);
 
   return true;
 }
 
-bool PdfPsMetafile::SaveTo(const base::FileDescriptor& fd) const {
+bool PdfPsMetafile::SaveTo(const FilePath& file_path) const {
   // We need to check at least these two members to ensure that either Init()
   // has been called to initialize |data_|, or metafile has been closed.
   DCHECK(!context_);
   DCHECK(!data_.empty());
 
-  if (fd.fd < 0) {
-    DLOG(ERROR) << "Invalid file descriptor!";
-    return false;
-  }
-
   bool success = true;
-  if (file_util::WriteFileDescriptor(fd.fd, data_.data(),
-                                     GetDataSize()) < 0) {
-    DLOG(ERROR) << "Failed to save file with fd " << fd.fd;
+  if (file_util::WriteFile(file_path,

[vandebo (ex-Chrome), 2011/03/08 00:39:35]

Fits on one line now.

[dpapad, 2011/03/08 19:39:22]

Done.

+                           data_.data(),
+                           GetDataSize()) < 0) {
+    DLOG(ERROR) << "Failed to save file " << file_path.value().c_str();
     success = false;
   }
-
-  if (fd.auto_close) {
-    if (HANDLE_EINTR(close(fd.fd)) < 0) {
-      DPLOG(WARNING) << "close";
-      success = false;
-    }
-  }
-
   return success;
 }
 
 PdfPsMetafile* PdfPsMetafile::FromCairoContext(cairo_t* context) {
   return reinterpret_cast<PdfPsMetafile*>(
       cairo_get_user_data(context, &kPdfMetafileKey));
 }
 
 void PdfPsMetafile::CleanUpAll() {
   CleanUpContext(&context_);
   CleanUpSurface(&surface_);
   data_.clear();
   skia::VectorPlatformDevice::ClearFontCache();
 }
 
 const double PdfPsMetafile::kTopMarginInInch = 0.25;
 const double PdfPsMetafile::kBottomMarginInInch = 0.56;
 const double PdfPsMetafile::kLeftMarginInInch = 0.25;
 const double PdfPsMetafile::kRightMarginInInch = 0.25;
 
 }  // namespace printing