Issue 6611030: Move cookies tree model helper code into cookies_tree_model_util.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6611030: Move cookies tree model helper code into cookies_tree_model_util. (Closed)

Created:
9 years, 9 months ago by xiyuan

Modified:
9 years, 7 months ago

Reviewers:
Mike Mammarella

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move cookies tree model helper code into cookies_tree_model_util. So that the logic could be reused for the upcoming cookie prompt webui. BUG=chromium-os:8134 TEST=Verify this CL does not break the cookies view in settings UI. Don't verify chromium-os:8134 yet as the change for it depends on this CL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77168

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix typo #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+273 lines, -212 lines)			Patch
A	chrome/browser/ui/webui/cookies_tree_model_util.h	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/webui/cookies_tree_model_util.cc	View		1 chunk	+221 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/cookies_view_handler.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/cookies_view_handler.cc	View	1	6 chunks	+16 lines, -209 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

LGTM http://codereview.chromium.org/6611030/diff/1/chrome/browser/ui/webui/options/cookies_view_handler.cc File chrome/browser/ui/webui/options/cookies_view_handler.cc (right): http://codereview.chromium.org/6611030/diff/1/chrome/browser/ui/webui/options/cookies_view_handler.cc#newcode120 chrome/browser/ui/webui/options/cookies_view_handler.cc:120: CookieTreeNode* parend_node = cookies_tree_model_->AsNode(parent); parent_node?

9 years, 9 months ago (2011-03-04 01:05:12 UTC) #2

xiyuan

9 years, 9 months ago (2011-03-04 17:00:44 UTC) #3

Done and submitting...

http://codereview.chromium.org/6611030/diff/1/chrome/browser/ui/webui/options...
File chrome/browser/ui/webui/options/cookies_view_handler.cc (right):

http://codereview.chromium.org/6611030/diff/1/chrome/browser/ui/webui/options...
chrome/browser/ui/webui/options/cookies_view_handler.cc:120: CookieTreeNode*
parend_node = cookies_tree_model_->AsNode(parent);
On 2011/03/04 01:05:12, Mike Mammarella wrote:
> parent_node?

Oops. Fixed. :p

Expand Messages | Collapse Messages