chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 6611023: The optional Malware Details also collects HTTP cache information. See design...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 6611023: The optional Malware Details also collects HTTP cache information. See design... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/safe_browsing/malware_details_cache.cc ('K') | « chrome/browser/safe_browsing/report.proto ('k') | chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

===================================================================

--- chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (revision 81745)

+++ chrome/browser/safe_browsing/safe_browsing_blocking_page.cc (working copy)

@@ -147,7 +147,7 @@

malware_details_ == NULL &&

CanShowMalwareDetailsOption()) {

malware_details_ = MalwareDetails::NewMalwareDetails(

- tab(), unsafe_resources[0]);

+ sb_service_, tab(), unsafe_resources[0]);

}

@@ -605,12 +605,11 @@

bool value;

if (pref && pref->GetValue()->GetAsBoolean(&value) && value) {

- // Give the details object to the service class, so it can send it.

+ // Finish the malware details collection, send it over.

BrowserThread::PostTask(

BrowserThread::IO, FROM_HERE,

NewRunnableMethod(

- sb_service_, &SafeBrowsingService::ReportMalwareDetails,

- malware_details_));

+ malware_details_.get(), &MalwareDetails::FinishCollection));

}