Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3002)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 6611023: The optional Malware Details also collects HTTP cache information. See design... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.cc
===================================================================
--- chrome/browser/safe_browsing/safe_browsing_service.cc (revision 80624)
+++ chrome/browser/safe_browsing/safe_browsing_service.cc (working copy)
@@ -1066,14 +1066,13 @@
}
// If the user had opted-in to send MalwareDetails, this gets called
-// at the time that the blocking page is going away.
-void SafeBrowsingService::ReportMalwareDetails(
- scoped_refptr<MalwareDetails> details) {
+// when the report is ready.
+void SafeBrowsingService::SendSerializedMalwareDetails(
+ const std::string& serialized) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- scoped_ptr<const std::string> serialized(details->GetSerializedReport());
- if (!serialized->empty()) {
+ if (!serialized.empty()) {
DVLOG(1) << "Sending serialized malware details.";
- protocol_manager_->ReportMalwareDetails(*serialized);
+ protocol_manager_->ReportMalwareDetails(serialized);
}
}

Powered by Google App Engine
This is Rietveld 408576698