Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Issue 6611013: Enable joining of IBSS (AdHoc) networks (Closed)

Created:
9 years, 9 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
Sam Leffler
CC:
chromium-os-reviews_chromium.org, sleffler+cc_chromium.org, Nathan Williams, Eric Shienbrood, Jason Glasgow, rochberg, Paul Stewart
Visibility:
Public.

Description

Enable joining of IBSS (AdHoc) networks Set wpa_supplicant parameters for IBSS networks, namely setting both mode and frequency (since wpa_supplicant doesn't use scan results to determine which frequency to do the IBSS on). BUG=chromium-os:12042 TEST=Manual -- join manually created IBSS. Also tested with new IBSS test in MatFunc: (issue 6603026) Change-Id: I893453c69f275d23ab80adb8c5fb90e875b54020 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ff47411

Patch Set 1 #

Total comments: 4

Patch Set 2 : Respond to Sam's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M plugins/newwifi.c View 1 3 chunks +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paul Stewart
9 years, 9 months ago (2011-03-03 08:28:37 UTC) #1
Sam Leffler
I take it this gets us a connection via dbus? Or can we also now ...
9 years, 9 months ago (2011-03-03 15:51:06 UTC) #2
Paul Stewart
PTAL. Added autotest as well. http://codereview.chromium.org/6611013/diff/1/plugins/newwifi.c File plugins/newwifi.c (right): http://codereview.chromium.org/6611013/diff/1/plugins/newwifi.c#newcode902 plugins/newwifi.c:902: } else if (g_ascii_strcasecmp(mode_str, ...
9 years, 9 months ago (2011-03-03 21:59:26 UTC) #3
Sam Leffler
9 years, 9 months ago (2011-03-03 22:16:15 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698