Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 6611009: Add the nand device support for cbootimage tool. (Closed)

Created:
9 years, 9 months ago by pchen
Modified:
9 years, 7 months ago
Reviewers:
robotboy, jimmzhang
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add the nand device support for cbootimage tool. Change-Id: Ic24dd4c971c16d00742d90830be168b41483be7a BUG=None. TEST=Test with the config file. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=053d578

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -17 lines) Patch
M cbootimage.h View 1 chunk +1 line, -3 lines 0 comments Download
M cbootimage.c View 1 chunk +2 lines, -0 lines 1 comment Download
M data_layout.h View 1 chunk +3 lines, -0 lines 0 comments Download
M data_layout.c View 3 chunks +2 lines, -2 lines 1 comment Download
M nvbctlib.h View 1 chunk +6 lines, -0 lines 0 comments Download
M nvbctlib_ap20.c View 3 chunks +13 lines, -0 lines 0 comments Download
M parse.h View 2 chunks +5 lines, -0 lines 0 comments Download
M parse.c View 4 chunks +29 lines, -12 lines 0 comments Download
M set.h View 1 chunk +6 lines, -0 lines 0 comments Download
M set.c View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pchen
9 years, 9 months ago (2011-03-03 05:54:37 UTC) #1
robotboy
LGTM, with a couple of questions below. I'll push it as is because it passes ...
9 years, 9 months ago (2011-03-03 18:08:46 UTC) #2
robotboy
On 2011/03/03 18:08:46, robotboy wrote: > LGTM, with a couple of questions below. I'll push ...
9 years, 9 months ago (2011-03-03 18:09:30 UTC) #3
pchen
9 years, 9 months ago (2011-03-04 02:18:04 UTC) #4
On 2011/03/03 18:09:30, robotboy wrote:

The previous cbootimage was designed only use for edit the existing .bct file
then append the bootloader and google component.
I add the code you point out above to correctly generate the .bct file just base
on the description in config file, in that case no existing .bct for reference.

I'm not quite understand you description in issue-12712, do you mean if the
cbootimage modify the boot device field of .bct file, the generated image will
not boot?

Powered by Google App Engine
This is Rietveld 408576698