Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1377)

Unified Diff: src/scripts/mod_image_for_test.sh

Issue 661061: Fix problem with mod_image_for_test leaving dangling chroot ref (Closed)
Patch Set: needs sudo Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/scripts/mod_for_test_scripts/700enableNewLoginManager ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scripts/mod_image_for_test.sh
diff --git a/src/scripts/mod_image_for_test.sh b/src/scripts/mod_image_for_test.sh
index 98706d92d238e88ad746b87ff2d0767e744deddc..ef783a98d034bab0e049ba06ee2cf362eb89c2ee 100755
--- a/src/scripts/mod_image_for_test.sh
+++ b/src/scripts/mod_image_for_test.sh
@@ -50,6 +50,10 @@ cleanup_rootfs_mounts() {
echo "Killing process that has open file on our rootfs: $cmdline"
! sudo kill $pid # Preceded by ! to disable ERR trap.
done
+ if [[ -d "${ROOT_FS_DIR}/modify_scripts" ]]; then
+ echo "Cleaned up modify_scripts mount"
+ ! sudo umount "${ROOT_FS_DIR}/modify_scripts"
+ fi
}
cleanup_rootfs_loop() {
@@ -97,6 +101,7 @@ fi
MOD_SCRIPTS_ROOT="${GCLIENT_ROOT}/src/scripts/mod_for_test_scripts"
sudo mkdir -p "${ROOT_FS_DIR}/modify_scripts"
+
sudo mount --bind "${MOD_SCRIPTS_ROOT}" "${ROOT_FS_DIR}/modify_scripts"
# Run test setup script inside chroot jail to modify the image
« no previous file with comments | « src/scripts/mod_for_test_scripts/700enableNewLoginManager ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698