Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4573)

Unified Diff: chrome/common/extensions/extension.cc

Issue 661019: Add command line option to use a tabbed bookmark manager (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension.cc
===================================================================
--- chrome/common/extensions/extension.cc (revision 40140)
+++ chrome/common/extensions/extension.cc (working copy)
@@ -64,7 +64,11 @@
if (str == Extension::kPermissionNames[i]) {
if (str == Extension::kExperimentalPermission &&
!CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kEnableExperimentalExtensionApis)) {
+ switches::kEnableExperimentalExtensionApis) &&
+ // TODO(arv): Tighten this so that not all extensions can access the
+ // experimental APIs.
+ !CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableTabbedBookmarkManager)) {
return false;
}
return true;
@@ -1282,7 +1286,8 @@
// this check, but let's keep it simple for now.
// TODO(erikkay) enable other pages as well
std::string val;
- if ((page != chrome::kChromeUINewTabHost) ||
+ if ((page != chrome::kChromeUINewTabHost &&
+ page != chrome::kChromeUIBookmarksHost) ||
!overrides->GetStringWithoutPathExpansion(*iter, &val)) {
*error = errors::kInvalidChromeURLOverrides;
return false;
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | chrome/common/url_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698