Fix autoupdate to be backwards compatible with previous releases.

Fix autoupdate to be backwards compatible with previous releases.
If the "board" attribute is not set, then assume "x86-generic"

[petkov, 2010-02-24 20:42:44]

http://codereview.chromium.org/661005/diff/1001/4
File src/platform/dev/autoupdate.py (right):

http://codereview.chromium.org/661005/diff/1001/4#newcode98
src/platform/dev/autoupdate.py:98: client_version =
query.getAttribute('version');
No semicolon at the end

http://codereview.chromium.org/661005/diff/1001/4#newcode99
src/platform/dev/autoupdate.py:99: board_id = query.hasAttribute('board') and
query.getAttribute('board') or "x86-generic";
No semicolon, 80 chars.
For some reason I'm still getting exception here when I try it:
172.22.69.23:55471 - - [24/Feb/2010 20:39:07] "HTTP/1.1 POST /update" - 500
Internal Server Error
Traceback (most recent call last):
  File "/usr/lib64/python2.6/site-packages/web/application.py", line 242, in
process
    return self.handle()
  File "/usr/lib64/python2.6/site-packages/web/application.py", line 233, in
handle
    return self._delegate(fn, self.fvars, args)
  File "/usr/lib64/python2.6/site-packages/web/application.py", line 412, in
_delegate
    return handle_class(cls)
  File "/usr/lib64/python2.6/site-packages/web/application.py", line 387, in
handle_class
    return tocall(*args)
  File "devserver.py", line 28, in POST
    return updater.HandleUpdatePing(web.data())
  File "/home/petkov/trunk/src/platform/dev/autoupdate.py", line 99, in
HandleUpdatePing
    board_id = query.hasAttribute('board') and query.getAttribute('board') or
"x86-generic"
  File "/usr/lib64/python2.6/xml/dom/minidom.py", line 530, in __getitem__
    return self._attrs[attname_or_tuple]
KeyError: 'board'

[Charlie Lee, 2010-02-24 20:54:10]

I went ahead and fixed the other 80 chars issues.

http://codereview.chromium.org/661005/diff/1001/4
File src/platform/dev/autoupdate.py (right):

http://codereview.chromium.org/661005/diff/1001/4#newcode98
src/platform/dev/autoupdate.py:98: client_version =
query.getAttribute('version');
On 2010/02/24 20:42:45, petkov wrote:
> No semicolon at the end

Done.

http://codereview.chromium.org/661005/diff/1001/4#newcode99
src/platform/dev/autoupdate.py:99: board_id = query.hasAttribute('board') and
query.getAttribute('board') or "x86-generic";
On 2010/02/24 20:42:45, petkov wrote:
> No semicolon, 80 chars.
> For some reason I'm still getting exception here when I try it:
> 172.22.69.23:55471 - - [24/Feb/2010 20:39:07] "HTTP/1.1 POST /update" - 500
> Internal Server Error
> Traceback (most recent call last):
>   File "/usr/lib64/python2.6/site-packages/web/application.py", line 242, in
> process
>     return self.handle()
>   File "/usr/lib64/python2.6/site-packages/web/application.py", line 233, in
> handle
>     return self._delegate(fn, self.fvars, args)
>   File "/usr/lib64/python2.6/site-packages/web/application.py", line 412, in
> _delegate
>     return handle_class(cls)
>   File "/usr/lib64/python2.6/site-packages/web/application.py", line 387, in
> handle_class
>     return tocall(*args)
>   File "devserver.py", line 28, in POST
>     return updater.HandleUpdatePing(web.data())
>   File "/home/petkov/trunk/src/platform/dev/autoupdate.py", line 99, in
> HandleUpdatePing
>     board_id = query.hasAttribute('board') and query.getAttribute('board') or
> "x86-generic"
>   File "/usr/lib64/python2.6/xml/dom/minidom.py", line 530, in __getitem__
>     return self._attrs[attname_or_tuple]
> KeyError: 'board'
> 

Done.

[petkov, 2010-02-24 20:59:39]

LGTM. Thanks and sorry about the confusion.