Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 6610022: Enable speech input by default and remove unused code. (Closed)

Created:
9 years, 9 months ago by Satish
Modified:
9 years, 7 months ago
Reviewers:
andreip3000
CC:
chromium-reviews, jam, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Enable speech input by default and remove unused code. This CL is the same as what I submitted for M10 in http://codereview.chromium.org/6133006/, but rolled back then. We are now enabling the feature for M11. BUG=61677 TEST=browser_tests --gtest_filter="SpeechInputBrowserTest.*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -83 lines) Patch
M chrome/browser/renderer_host/browser_render_process_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/speech/speech_input_manager.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/renderer/render_thread.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/renderer/render_thread.cc View 3 chunks +2 lines, -9 lines 0 comments Download
M content/browser/speech/speech_input_browsertest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/speech/speech_input_dispatcher_host.cc View 1 chunk +12 lines, -24 lines 0 comments Download
M content/browser/speech/speech_input_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Satish
9 years, 9 months ago (2011-03-03 18:34:02 UTC) #1
andreip3000
9 years, 9 months ago (2011-03-03 18:39:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698