Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/util/lastchange.py

Issue 6610013: Added check for None missed in recent commit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/util/lastchange.py
diff --git a/build/util/lastchange.py b/build/util/lastchange.py
index e213d8b292fd00b3ccd4304349e445a1eeda3e7d..75176f0737a7f5f00c5b739142ca1254b0ac2e2a 100755
--- a/build/util/lastchange.py
+++ b/build/util/lastchange.py
@@ -115,7 +115,9 @@ def IsGitSVN(directory):
# svn-related configuration. This command exits with an error code
# if there aren't any matches, so ignore its output.
proc = RunGitCommand(directory, ['config', '--get-regexp', '^svn'])
- return (proc.wait() == 0)
+ if proc:
+ return (proc.wait() == 0)
+ return false
fta 2011/03/03 12:54:40 must be "False" instead
def FetchGitSVNURL(directory):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698