Issue 6610013: Added check for None missed in recent commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6610013: Added check for None missed in recent commit. (Closed)

Created:
9 years, 9 months ago by Denis Lagno

Modified:
9 years, 6 months ago

Reviewers:
fta

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Added check for None missed in recent commit. Reported by fta At sofaraway.org BUG=None TEST=None TBR=evan@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76733

Patch Set 1 #

Total comments: 1

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	build/util/lastchange.py	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

fta

typo http://codereview.chromium.org/6610013/diff/1/build/util/lastchange.py File build/util/lastchange.py (right): http://codereview.chromium.org/6610013/diff/1/build/util/lastchange.py#newcode120 build/util/lastchange.py:120: return false must be "False" instead

9 years, 9 months ago (2011-03-03 12:54:40 UTC) #1

Denis Lagno

9 years, 9 months ago (2011-03-03 13:01:09 UTC) #2

> build/util/lastchange.py:120: return false
> must be "False" instead

Committed: http://codereview.chromium.org/6618001

Expand Messages | Collapse Messages