[linux_views][Win] spoof proof redesign infobar extension with tab.

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #if defined(OS_LINUX)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 1788 matching lines @@
     gfx::Insets insets(GetFindBarBoundingBox().y() + 1,
                        0,
                        0,
                        0);
     aeropeek_manager_->SetContentInsets(insets);
   }
 #endif
 }
 
 void BrowserView::PaintChildren(gfx::Canvas* canvas) {
-  views::ClientView::PaintChildren(canvas);
+  // Paint the |infobar_container_| last so that it may paint its
+  // overlapping tabs.
+  for (int i = 0, count = child_count(); i < count; ++i) {

[Peter Kasting, 2011/03/04 22:23:42]

Nit: Don't create a separate |count| temp.  child_count() is cheap, call it
directly in the comparison.

[Sheridan Rawlins, 2011/03/05 18:06:54]

FWIW, this was copied from views/view.cc

Done.

+    View* child = GetChildViewAt(i);
+    if (!child) {

[Peter Kasting, 2011/03/04 22:23:42]

Nit: Remove this conditional.

[Sheridan Rawlins, 2011/03/05 18:06:54]

FWIW, this was copied from views/view.cc

Done.

+      NOTREACHED() << "Should not have a NULL child View for index in bounds";
+      continue;
+    }
+    if (child != infobar_container_)
+      child->Paint(canvas);
+  }
 
-  infobar_container_->PaintInfoBarArrows(canvas->AsCanvasSkia(),
-                                         this,
-                                         GetInfoBarArrowCenterX());
+  infobar_container_->Paint(canvas);
 }
 
 void BrowserView::ViewHierarchyChanged(bool is_add,
                                        views::View* parent,
                                        views::View* child) {
   if (is_add && child == this && GetWidget() && !initialized_) {
     Init();
     initialized_ = true;
   }
 }
@@ skipping 749 matching lines @@
       l10n_util::GetStringUTF16(IDS_PRODUCT_NAME));
 
   return view;
 }
 #endif
 
 // static
 FindBar* BrowserWindow::CreateFindBar(Browser* browser) {
   return browser::CreateFindBar(static_cast<BrowserView*>(browser->window()));
 }