Fetch repository root for git-svn checkouts.

Fetch repository root for git-svn checkouts.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76890

[Denis Lagno, 2011-03-03 23:50:22]

please take a look

[Evan Martin, 2011-03-03 23:53:09]

http://codereview.chromium.org/6609039/diff/1/build/util/lastchange.py
File build/util/lastchange.py (right):

http://codereview.chromium.org/6609039/diff/1/build/util/lastchange.py#newcod...
build/util/lastchange.py:158: match = re.search(r'\S+$', output)
What is this regex for?  Does this command sometimes output empty lines?

Do you mean to have the re.MULTILINE attr on there or is it always going to
output a single line?

http://codereview.chromium.org/6609039/diff/1/build/util/lastchange.py#newcod...
build/util/lastchange.py:177: match = git_re.search(line)
I guess this could be .match() now

[Denis Lagno, 2011-03-04 00:15:21]

http://codereview.chromium.org/6609039/diff/1/build/util/lastchange.py
File build/util/lastchange.py (right):

http://codereview.chromium.org/6609039/diff/1/build/util/lastchange.py#newcod...
build/util/lastchange.py:158: match = re.search(r'\S+$', output)
On 2011/03/03 23:53:09, Evan Martin wrote:
> What is this regex for?  Does this command sometimes output empty lines?

Executing it on my checkout produces:

$ git config --get-regexp ^svn-remote.svn.url$
svn-remote.svn.url svn://svn.chromium.org/chrome

That is why I need regexp: to grab second field.

> Do you mean to have the re.MULTILINE attr on there or is it always going to
> output a single line?

I guess there is no need for MULTILINE because \S does not match newline.

http://codereview.chromium.org/6609039/diff/1/build/util/lastchange.py#newcod...
build/util/lastchange.py:177: match = git_re.search(line)
On 2011/03/03 23:53:09, Evan Martin wrote:
> I guess this could be .match() now

Done.

[Evan Martin, 2011-03-04 00:17:05]

LGTM

http://codereview.chromium.org/6609039/diff/3001/build/util/lastchange.py
File build/util/lastchange.py (right):

http://codereview.chromium.org/6609039/diff/3001/build/util/lastchange.py#new...
build/util/lastchange.py:158: match = re.search(r'\S+$', output)
Ah, I see.  You want to grab the right half of the output.
Can you put in a comment that shows what the form of the output is, and what
you're intending to match?

[Denis Lagno, 2011-03-04 00:49:21]

http://codereview.chromium.org/6609039/diff/3001/build/util/lastchange.py
File build/util/lastchange.py (right):

http://codereview.chromium.org/6609039/diff/3001/build/util/lastchange.py#new...
build/util/lastchange.py:158: match = re.search(r'\S+$', output)
On 2011/03/04 00:17:05, Evan Martin wrote:
> Ah, I see.  You want to grab the right half of the output.
> Can you put in a comment that shows what the form of the output is, and what
> you're intending to match?

Done.