Issue 6609038: Fix memory corruption with AdoptText method....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6609038: Fix memory corruption with AdoptText method.... (Closed)

Created:
9 years, 9 months ago by Nebojša Ćirić

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev, jungshik at Google

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix memory corruption with AdoptText method. Icu setText method keeps pointer to text, it doesn't copy it so we have to keep text around for the lifetime of the break iterator object, or next setText operation. Committed: http://code.google.com/p/v8/source/detail?r=7063

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -6 lines)			Patch
	M	src/extensions/experimental/break-iterator.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	src/extensions/experimental/break-iterator.cc	View		5 chunks	+26 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nebojša Ćirić

Tested on Mac, Win and Linux Chromium, and Mac WebKit tree, and all is good.

9 years, 9 months ago (2011-03-04 00:08:21 UTC) #1

LGTM

Expand Messages | Collapse Messages