Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Issue 6609016: Select factory image when --factory is given (Closed)

Created:
9 years, 9 months ago by sjg
Modified:
9 years, 7 months ago
Reviewers:
Nick Sanders, vb, sosa
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Select factory image when --factory is given prepare_test_image would prepare the correct image (test or factory) but its return value would always specify the test image. This meant that image_to_usb.sh would pick up the wrong image. This commit fixes this. BUG=chromium-os:12377 TEST=./image_to_usb --from=... --to=/dev/sdb also with --factory also with --test Make sure it picks up the correct image in each case. Change-Id: I165b604b448a6c938a47e57a667bd5f001626efe Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=6e448ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M common.sh View 1 chunk +5 lines, -1 line 0 comments Download
M mod_image_for_test.sh View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
sjg
Nick I'm not sure what happened here, but clearly it wasn't using the right image ...
9 years, 9 months ago (2011-03-03 05:26:35 UTC) #1
sosa
9 years, 9 months ago (2011-03-03 18:29:48 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698