rename OwnersFor() to ReviewersFor(), add SyntaxError exception, ANYONE wildcard constant

rename OwnersFor() to ReviewersFor(), add SyntaxError exception, ANYONE wildcard constant

neither SyntaxError or ANYONE is used at, but they will be shortly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76978

[M-A Ruel, 2011-03-03 16:16:25]

http://codereview.chromium.org/6609012/diff/1/owners.py
File owners.py (right):

http://codereview.chromium.org/6609012/diff/1/owners.py#newcode12
owners.py:12: def __init__(self, path, line, msg):
Call the constructor so self.args is set.
super(SyntaxError, self).__init__((path, line, msg))

but ...
How is this class different from
http://docs.python.org/library/exceptions.html#exceptions.SyntaxError ?

[Dirk Pranke, 2011-03-03 17:26:00]

On Thu, Mar 3, 2011 at 8:16 AM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/6609012/diff/1/owners.py
> File owners.py (right):
>
> http://codereview.chromium.org/6609012/diff/1/owners.py#newcode12
> owners.py:12: def __init__(self, path, line, msg):
> Call the constructor so self.args is set.
> super(SyntaxError, self).__init__((path, line, msg))
>

Will do.

> but ...
> How is this class different from
> http://docs.python.org/library/exceptions.html#exceptions.SyntaxError ?
>

According to the docs, that exception is for parsing Python code; it feels wrong
to me to reuse it for parsing other kinds of files.

-- Dirk

> http://codereview.chromium.org/6609012/
>

[M-A Ruel, 2011-03-03 17:28:07]

On 2011/03/03 17:26:00, dpranke wrote:
> According to the docs, that exception is for parsing Python code; it feels
wrong
> to me to reuse it for parsing other kinds of files.

The problem is that you alias the name.

[Dirk Pranke, 2011-03-03 17:29:42]

On Thu, Mar 3, 2011 at 9:28 AM,  <maruel@chromium.org> wrote:
> On 2011/03/03 17:26:00, dpranke wrote:
>>
>> According to the docs, that exception is for parsing Python code; it feels
>
> wrong
>>
>> to me to reuse it for parsing other kinds of files.
>
> The problem is that you alias the name.
>

Inside the module, I suppose that's true. Outside, it's scoped to the module
name. But, it's a fair point; I'll change the name.

-- Dirk

> http://codereview.chromium.org/6609012/
>

[Dirk Pranke, 2011-03-03 21:10:20]

updated.

[M-A Ruel, 2011-03-03 21:13:50]

http://codereview.chromium.org/6609012/diff/5001/owners.py
File owners.py (right):

http://codereview.chromium.org/6609012/diff/5001/owners.py#newcode13
owners.py:13: Exception.__init__(self, (path, line, msg))
Use the super() form please.

[Dirk Pranke, 2011-03-03 22:42:48]

Okay. Any particular reason, apart from the fact that it'll actually
work right in a
multiple-inheritance scenario, which shouldn't occur with exceptions? Others on
the team have preferred the non-super version in the past, which is why I didn't
use it (I actually prefer super myself).

-- Dirk

On Thu, Mar 3, 2011 at 1:13 PM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/6609012/diff/5001/owners.py
> File owners.py (right):
>
> http://codereview.chromium.org/6609012/diff/5001/owners.py#newcode13
> owners.py:13: Exception.__init__(self, (path, line, msg))
> Use the super() form please.
>
> http://codereview.chromium.org/6609012/
>

[M-A Ruel, 2011-03-04 14:49:36]

lgtm